Hi,

The [AspectBehavior(OpenTransaction = true)] does not work as expected : When entering a method with this attribute, I get a the following Exception : Unable to process operation without a transaction. Use Transaction.Open(...) to open it.

Here is some sample code :

[HierarchyRoot]
class Customer : Entity
{
    [Field, Key]
    public long Id { get; private set; }

    [Field]
    public string Name { get; set; }

    [AspectBehavior(OpenTransaction = true)]
    public void ChangeName(string newname)
    {
      Name = newname;
    }
}

in Main : 
[...]
      using (Session.Open(domain))
      {
        Customer foo;
        using (TransactionScope transactionScope = Transaction.Open())
        {
          foo = Query<Customer>.All.First();
          transactionScope.Complete(); 
        }
        // exception is thrown here : 
        foo.ChangeName("My new name"); 
      }

Apparently, the attribute does not open any transaction. Thank you for your feedback Best regards,

Auguste

Updated at 14.09.2009 14:46:29

Hi,

Thank you for your feedback

In this case [AspectBehavior] really shouldn't change anything: [...] Could you publish a complete stack trace? Does removal of attribute change the behavior?

No, the removal of the attribute does not change anything indeed. In fact, the bug is easy to reproduce. Please find hereafter the complete code needed to reproduce the bug. Version used is the latest nightly build available on 2009-09-11

namespace BuildDomain
{
  [HierarchyRoot]
  class Customer : Entity
  {
    [Field, Key]
    public long Id { get; private set; }

    [Field]
    public string Name { get; set; }

    public void ChangeName(string newname)
    {
      Name = newname;
    }
  }

  class Program
  {

    static void Main(string[] args)
    {
      DomainConfiguration DoConfiguration = new DomainConfiguration(@"sqlserver://localhost\SQLEXPRESS/DOtests");
      DoConfiguration.Types.Register(System.Reflection.Assembly.GetAssembly(typeof(Customer)));
      DoConfiguration.UpgradeMode = DomainUpgradeMode.Recreate;
      Domain domain = Domain.Build(DoConfiguration);
      Console.WriteLine("Domain is built.");

      using (Session.Open(domain))
      using (TransactionScope transactionScope = Transaction.Open())
      {
        Customer toto = new Customer { Name = "toto" };
        transactionScope.Complete();
      }

      Customer foo; 
      using (Session.Open(domain))
      {
        using (TransactionScope transactionScope = Transaction.Open())
        {
          foo = Query<Customer>.All.First();
          transactionScope.Complete(); 
        }
        foo.ChangeName("My new name"); 
      }

      Console.WriteLine("Press any key to exit");
      Console.ReadLine();
    }

  }
}

Here is the corresponding full stack trace

L'exception System.InvalidOperationException n'a pas été gérée
  Message="Unable to process operation without a transaction. Use Transaction.Open(...) to open it."
  Source="Xtensive.Storage"
  StackTrace:
       at Xtensive.Storage.Session.OpenTransaction(IsolationLevel isolationLevel, Boolean autoTransaction)
       at Xtensive.Storage.Session.OpenTransaction(Boolean autoTransaction)
       at Xtensive.Storage.Transaction.Open(Session session, Boolean autoTransaction)
       at Xtensive.Storage.Aspects.TransactionalAspect.OnEntry(Object instance)
       at BuildDomain.Customer.ChangeName(String newname) in D:\Perforce\aradus\Projets\ProjetsPerso\avenkiah\DO4\BuildDomain\BuildDomain\Program.cs:line 22
       at BuildDomain.Program.Main(String[] args) in D:\Perforce\aradus\Projets\ProjetsPerso\avenkiah\DO4\BuildDomain\BuildDomain\Program.cs:line 53
       at System.AppDomain._nExecuteAssembly(Assembly assembly, String[] args)
       at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
       at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
       at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
       at System.Threading.ThreadHelper.ThreadStart()
  InnerException:

Updated at 15.09.2009 16:53:03

Thank you all for your feedback on this problem !

@Otto : Thank you very much for this fix.

@Alex : I am indeed interested with nightly builds and latest bug fixes !

In this case [AspectBehavior] really shouldn't change anything: - You can consider its default property values for any public SessionBound method are OpenTransaction = true, OpenSession = true

Given Otto's fix, I find it confusing that SessionOptions.AutoTransactions is off by default.

@Dimitri : I agree with you. Moreover, I find it easier to set the set options in DomainConfiguration : creating a new SessionConfiguration and adding it to DomainConfiguration.Sessions is not very straightforward. Anyway, it is easy use [AspectBehavior] to locally change the transactions behavior.

Best regards,

Auguste

This thread was imported from our support forum. The original discussion may contain more detailed answer.