This issue is related to old version of DataObjects.Net!

We have found an issue in version 3.9.5 where the domain upgrade seems to erroneously delete records in a ValueTypeCollection table. If I dump the SchemaUpdateSQL.txt it shows the problem commands. In this example we have removed a base type in the object hierarchy so the number of records it is deleting is large.

First it gets a list of the types that need to be deleted.

Create table #idTable (ID bigint primary key)
Insert into #idTable Select distinct [dbo].[doDataObject].[ID] as ID from [dbo].[doDataObject] where [dbo].[doDataObject].[TypeID] in (70, 105, 39, 119)

Next it nullifies any references that may be pointing to these types.

Update [dbo].[doItemBase] set [Category] = 0 where [Category] in (Select ID from #idTable)

Finally it deletes any records that are of these types.

Delete from [dbo].[doItem] where [ID] in (Select ID from #idTable)

The problem is when it performs the same action for a ValueTypeCollection. ValueTypeCollection tables have their own IdGenerator tables and as such their identity generation is self-contained. Therefore if the command above is executed against a ValueTypeCollection table it will remove unwanted records.

The domain upgrade executes these commands against ValueTypeCollections:

Delete from [dbo].[doRelationship-AggregateKeys] where [ID] in (Select ID from #idTable)

Delete from [dbo].[doRelationship-AggregateKeys] where [Owner] in (Select ID from #idTable)

The second delete is fine as the owner of the ValueTypeCollection is a dataobject and may need to be removed. The problem is the first command as the IDs are self-contained in the ValueTypeCollection and may exist in the #idtable list. It can then mistakenly remove a whole host of ValueType records where the intention was to clean up a removed dataobject type.

Please respond ASAP as this is effecting production code.

Thanks,

Simon